secure-ntp: label /run/chrony-dhcp so chronyd can read the NTS source under SELinux

Second bench defect after removing the distro 20-chrony-dhcp clobberer
(secure-ntp-5a3eaed, comet-beacon-54): the dispatcher wrote the correct
`server ntp.fleet.lab iburst nts` line, but chrony loaded ZERO sources --
`chronyc reload sources` returned 200 OK yet authdata/sources stayed empty.

Root cause (AVC): chronyd_t was DENIED read on the .sources files because they and
/run/chrony-dhcp itself were labeled generic var_run_t; chronyd_t may only read its
own chronyd_var_run_t. The dispatcher's `mkdir -p` creates the dir as var_run_t and
files inherit it. The distro 20-chrony-dhcp we removed had been restorecon-ing them
to the readable label, so removing it exposed a latent labelling gap.

Stock RHEL policy already maps /run/chrony-dhcp -> chronyd_var_run_t (a restorecon
relabels it and chrony immediately reaches NTS Cook 8). Fix: ship
/etc/tmpfiles.d/chrony-dhcp.conf so systemd-tmpfiles pre-creates the dir with that
fcontext at sysinit, before any NM event -- the dispatcher's files then inherit
chronyd_var_run_t and chronyd can read them. No SELinux allow rules needed
(bench-verified: after the fix a real NM event wrote the source as chronyd_var_run_t,
no AVC, authdata -> NTS Cook 8). Applies in both secure_ntp modes.

Also: the dispatcher now skips `lo` -- it was writing a spurious lo.sources
duplicate of the same server (the distro script had skipped loopback).

BENCH-VERIFY on the next clean build: a normal boot leaves the source file labeled
chronyd_var_run_t (ls -Z), no lo.sources, and authdata reaches NTS/cookies>0 with no
manual step.
This commit is contained in:
Audiobuzz
2026-07-12 02:53:05 +00:00
parent 5a3eaedec5
commit 5294860e74
5 changed files with 79 additions and 6 deletions
@@ -27,7 +27,11 @@
# /usr/lib/NetworkManager/dispatcher.d/20-chrony-dhcp writing option-42 servers to
# the SAME <iface>.sources. NM merges /etc + /usr/lib sorted by name, so it runs
# AFTER us and would clobber the NTS line — the provisioner removes it (it defeated
# NTS on the bench: chrony fell back to plain NTP). This script supersedes it.
# NTS on the bench: chrony fell back to plain NTP). This script supersedes it. It
# was ALSO (accidentally) labelling the sources chronyd_var_run_t so chronyd could
# read them; we restore that via /etc/tmpfiles.d/chrony-dhcp.conf (see the dir note
# below) — without it, under enforcing SELinux chronyd can't read the sources and
# loads nothing (bench 2026-07-12).
MODE="@NTP_MODE@" # nts | dhcp
PREFIX="@NTP_PREFIX@" # nts: server name = <PREFIX>.<dhcp-domain>
@@ -40,6 +44,15 @@ case "$action" in
*) exit 0 ;;
esac
# Loopback carries no DHCP NTP config; acting on it just writes a spurious
# lo.sources duplicate of the same server (the distro 20-chrony-dhcp skipped lo —
# we must too, or chrony sees two files for one server). Skip it.
[ "$interface" = lo ] && exit 0
# /run/chrony-dhcp is pre-created with the chronyd_var_run_t SELinux label by
# /etc/tmpfiles.d/chrony-dhcp.conf at boot, so the files we write below inherit a
# label chronyd_t can READ (else, under enforcing, chronyd is denied and loads no
# sources — bench 2026-07-12). This mkdir is just a fallback if tmpfiles didn't run.
dir=/run/chrony-dhcp
file="$dir/${interface}.sources"
mkdir -p "$dir"